Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 19 Aug 2021 06:44:27 -0700 | Subject | Re: [PATCH V1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC |
| |
Hi,
On Tue, Aug 17, 2021 at 6:58 AM Doug Anderson <dianders@google.com> wrote: > > > pinconf-data { > > pins = "sdc1_data"; > > bias-pull-up; > > - drive-strength = <10>; > > + drive-strength = <16>; > > I could be convinced that this is the right thing to do, but I want to > really make sure that it has had sufficient testing. Specifically as > this patch is written we'll be updating the drive strength for all > boards. Increasing the drive strength can sometimes introduce new > problems (reflections, noise, ...) so we have to be confident that > we're not breaking someone that used to work by increasing the drive > strength here. How much has this been tested?
From further discussion internally, it sounds as if this should be fine and fixes more than just this one eMMC part. Thus:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |