Messages in this thread Patch in this message | | | From | Tang Bin <> | Subject | [PATCH] power: supply: cpcap-battery: remove redundant check | Date | Thu, 19 Aug 2021 20:11:37 +0800 |
| |
In the function cpcap_battery_probe(), the check of '!match->data' can actually never happen for the driver. First, this probe function will only be called if there is a match with an entry from the OF device ID table, and then all entries have .data set to a valid point. So remove the redundant check.
Co-developed-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- drivers/power/supply/cpcap-battery.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c index 8d62d4241..a3866826b 100644 --- a/drivers/power/supply/cpcap-battery.c +++ b/drivers/power/supply/cpcap-battery.c @@ -1035,12 +1035,6 @@ static int cpcap_battery_probe(struct platform_device *pdev) if (!match) return -EINVAL; - if (!match->data) { - dev_err(&pdev->dev, "no configuration data found\n"); - - return -ENODEV; - } - ddata = devm_kzalloc(&pdev->dev, sizeof(*ddata), GFP_KERNEL); if (!ddata) return -ENOMEM; -- 2.20.1.windows.1
| |