Messages in this thread Patch in this message | | | From | Bard Liao <> | Subject | [PATCH] soundwire: bus: filter out more -EDATA errors on clock stop | Date | Wed, 14 Jul 2021 09:42:09 +0800 |
| |
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
We've added quite a few filters to avoid throwing errors if a Device does not respond to commands during the clock stop sequences, but we missed one.
This will lead to an isolated message [ 6115.294412] soundwire sdw-master-1: SDW_SCP_STAT bread failed:-61
The callers already filter this error code, so there's no point in keeping it at the lower level.
Since this is a recoverable error, make this dev_err() conditional and only log cases with Command Failed.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> --- drivers/soundwire/bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 3e6d4addac2f..278a4fbdb88d 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -896,7 +896,8 @@ static int sdw_bus_wait_for_clk_prep_deprep(struct sdw_bus *bus, u16 dev_num) do { val = sdw_bread_no_pm(bus, dev_num, SDW_SCP_STAT); if (val < 0) { - dev_err(bus->dev, "SDW_SCP_STAT bread failed:%d\n", val); + if (val != -ENODATA) + dev_err(bus->dev, "SDW_SCP_STAT bread failed:%d\n", val); return val; } val &= SDW_SCP_STAT_CLK_STP_NF; -- 2.17.1
| |