lkml.org 
[lkml]   [2021]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [smartpqi updates V2 PATCH 8/9] smartpqi: fix isr accessing uninitialized data
From
Date
On 7/13/21 4:02 PM, Don Brace wrote:
> From: Mike McGowen <mike.mcgowen@microchip.com>
>
> Correct driver's ISR accessing a data structure member
> that has not been fully initialized during driver
> initialization.
> - The pqi queue groups can have uninitialized members
> when an interrupt fires. This has not resulted in
> any driver crashes. This was found during our own
> internal testing. No bugs were ever filed.
>
> Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
> Reviewed-by: Scott Teel <scott.teel@microchip.com>
> Signed-off-by: Mike McGowen <mike.mcgowen@microchip.com>
> Signed-off-by: Don Brace <don.brace@microchip.com>


Acked-by : John Donnelly <john.p.donnelly@oracle.com>

> ---
> drivers/scsi/smartpqi/smartpqi_init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
> index f0e84354f782..ab1c9c483478 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -7760,11 +7760,11 @@ static int pqi_ctrl_init(struct pqi_ctrl_info *ctrl_info)
>
> pqi_init_operational_queues(ctrl_info);
>
> - rc = pqi_request_irqs(ctrl_info);
> + rc = pqi_create_queues(ctrl_info);
> if (rc)
> return rc;
>
> - rc = pqi_create_queues(ctrl_info);
> + rc = pqi_request_irqs(ctrl_info);
> if (rc)
> return rc;
>
>

\
 
 \ /
  Last update: 2021-07-14 03:18    [W:0.121 / U:1.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site