lkml.org 
[lkml]   [2021]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] spi: cadence-quadspi: Fix check condition for DTR ops
On Tue, Jul 13, 2021 at 12:57:42PM +0000, Apurva Nandan wrote:

> + f_pdata->dtr = op->cmd.dtr &&
> + (op->addr.dtr || !op->addr.nbytes) &&
> + (op->data.dtr || !op->data.nbytes);

I'm not sure anyone reading this code is going to figure out what it's
doing without thinking about it, the combination of writing the bytes
check with a !, putting it after the check for .dtr and not having any
comments is a bit obscure. Something like

(op->addr.nbytes && op.addr.dtr)

might be a bit clearer, or a comment explicitly spelling it out.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-07-13 20:41    [W:0.040 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site