Messages in this thread | | | Date | Tue, 13 Jul 2021 18:59:54 +0200 (CEST) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH] net: fddi: fix UAF in fza_probe |
| |
On Tue, 13 Jul 2021, Pavel Skripkin wrote:
> fp is netdev private data and it cannot be > used after free_netdev() call. Using fp after free_netdev() > can cause UAF bug. Fix it by moving free_netdev() after error message.
Can you justify the lines for a better layout? The paragraph looks odd to me in its current form.
> Fixes: 61414f5ec983 ("FDDI: defza: Add support for DEC FDDIcontroller 700 > TURBOchannel adapter") > Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Otherwise LGTM. And a good catch, thank you!
Reviewed-by: Maciej W. Rozycki <macro@orcam.me.uk>
Maciej
| |