Messages in this thread | | | Date | Sat, 19 Jun 2021 12:08:29 +0200 | From | Jonathan Neuschäfer <> | Subject | Re: [PATCH 1/8] dt-bindings: arm/npcm: Add binding for global control registers (GCR) |
| |
On Tue, Jun 15, 2021 at 05:43:21PM -0600, Rob Herring wrote: > On Wed, Jun 02, 2021 at 02:03:22PM +0200, Jonathan Neuschäfer wrote: > > A nuvoton,*-gcr node is present in nuvoton-common-npcm7xx.dtsi and will > > be added to nuvoton-wpcm450.dtsi. It is necessary for the NPCM7xx and > > WPCM450 pinctrl drivers, and may later be used to retrieve SoC model and > > version information. > > > > This patch adds a binding to describe this node. > > > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > --- [...] > > +properties: > > + compatible: > > + items: > > + - enum: > > + - nuvoton,wpcm450-gcr > > + - nuvoton,npcm750-gcr > > + - const: syscon > > + - const: simple-mfd > > How is this a simple-mfd? There are no child nodes.
Some device trees, such as arch/arm/boot/dts/nuvoton-npcm730-gbs.dts, have subnodes of the GCR node (specifically, they (ab)use mmio-mux to set specific registers to specific values).
> > + reg: true > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + gcr: gcr@800000 { > > + compatible = "nuvoton,npcm750-gcr", "syscon", "simple-mfd"; > > + reg = <0x800000 0x1000>; > > + };
... I guess I should add a child node to the example, here.
Best regards, Jonathan Neuschäfer [unhandled content-type:application/pgp-signature] | |