lkml.org 
[lkml]   [2021]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v10 00/21] Fix v4l2-compliance errors
Date
*v4l2-compliance -m /dev/media0 -a -f
Total for uvcvideo device /dev/media0: 8, Succeeded: 6, Failed: 2, Warnings: 0
Total for uvcvideo device /dev/video0: 54, Succeeded: 50, Failed: 4, Warnings: 2
Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0
Grand Total for uvcvideo device /dev/media0: 108, Succeeded: 102,
Failed: 6, Warnings: 2

After fixing all of them we go down to:

Total for uvcvideo device /dev/media0: 8, Succeeded: 8, Failed: 0, Warnings: 0
Total for uvcvideo device /dev/video0: 54, Succeeded: 54, Failed: 0, Warnings: 0
Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0
Grand Total for uvcvideo device /dev/media0: 108, Succeeded: 108,
Failed: 0, Warnings: 0

YES, NO MORE WARNINGS :)

Note that we depend on:

https://patchwork.linuxtv.org/project/linux-media/patch/20210317143453.483470-1-ribalda@chromium.org/

With Hans patch we can also pass v4l2-compliance -s.


Changelog from v9 (Thanks to Hans and Laurent)

- Convert struct uvc_control_class into u32
- Rename uvc_control_class into uvc_control_classes
- Order of variables
- Do not duplicate error messages
- Move "Return -EACCES to inactive control" to the end

Hans Verkuil (4):
uvcvideo: uvc_ctrl_is_accessible: check for INACTIVE
uvcvideo: improve error handling in uvc_query_ctrl()
uvcvideo: don't spam the log in uvc_ctrl_restore_values()
uvc: use vb2 ioctl and fop helpers

Ricardo Ribalda (17):
media: v4l2-ioctl: Fix check_ext_ctrls
media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL
media: uvcvideo: Do not check for V4L2_CTRL_WHICH_DEF_VAL
media: v4l2-ioctl: S_CTRL output the right value
media: uvcvideo: Remove s_ctrl and g_ctrl
media: uvcvideo: Set capability in s_param
media: uvcvideo: Return -EIO for control errors
media: uvcvideo: refactor __uvc_ctrl_add_mapping
media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS
media: uvcvideo: Use dev->name for querycap()
media: uvcvideo: Set unique vdev name based in type
media: uvcvideo: Increase the size of UVC_METADATA_BUF_SIZE
media: uvcvideo: Use control names from framework
media: uvcvideo: Check controls flags before accessing them
media: uvcvideo: Set error_idx during ctrl_commit errors
media: docs: Document the behaviour of uvcvideo driver
media: uvcvideo: Return -EACCES to inactive controls

.../userspace-api/media/v4l/vidioc-g-ctrl.rst | 3 +
.../media/v4l/vidioc-g-ext-ctrls.rst | 3 +
drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 -
drivers/media/usb/uvc/uvc_ctrl.c | 339 +++++++++++----
drivers/media/usb/uvc/uvc_driver.c | 22 +-
drivers/media/usb/uvc/uvc_metadata.c | 10 +-
drivers/media/usb/uvc/uvc_queue.c | 143 -------
drivers/media/usb/uvc/uvc_v4l2.c | 389 +++---------------
drivers/media/usb/uvc/uvc_video.c | 43 +-
drivers/media/usb/uvc/uvcvideo.h | 50 +--
drivers/media/v4l2-core/v4l2-ioctl.c | 67 +--
11 files changed, 428 insertions(+), 645 deletions(-)

--
2.32.0.288.g62a8d224e6-goog

\
 
 \ /
  Last update: 2021-06-18 14:29    [W:0.277 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site