lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] iio: core: Support removing extended name in attribute filename
Hi Jonathan,

Le jeu., juin 10 2021 at 14:04:12 +0100, Jonathan Cameron
<Jonathan.Cameron@Huawei.com> a écrit :
> On Thu, 10 Jun 2021 15:58:51 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
>> On Thu, Jun 10, 2021 at 3:47 PM Paul Cercueil
>> <paul@crapouillou.net> wrote:
>> >
>> > By default, when a channel has an extended name, it will appear
>> in the
>> > filename of channel attributes. E.g. if the extended name is
>> "aux", the
>> > filename of a "sample_rate" attribute will be something like:
>> > in_voltage0_aux_sample_rate
>> >
>> > Add a mechanism to disable this feature. This will be used to add
>> a
>> > "extended_name" channel attribute.
>>
>> I'm afraid, NAK. Otherwise, please put an explanation that clearly
>> shows that it will be no ABI breakage.
>> I.o.w. users for the existing drivers and devices will always get
>> those attributes at the same platform configuration(s).
>>
>
> What Andy said. This was a bad design decision a long time back, but
> we are stuck with it.
>
> We have the _label attribute today that is the preferred route
> forwards
> for new drivers but we can't touch the old ones however annoying it
> might
> be.

You're missing the point here. This patchset only adds a new channel
attribute and doesn't change anything else.

The "label" is good to have, but that doesn't help me in any way. The
problem here is parseability.

Cheers,
-Paul


\
 
 \ /
  Last update: 2021-06-10 15:08    [W:0.059 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site