lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] iio: core: Support removing extended name in attribute filename
    On Thu, Jun 10, 2021 at 4:11 PM Jonathan Cameron
    <Jonathan.Cameron@huawei.com> wrote:
    > On Thu, 10 Jun 2021 14:05:53 +0100
    > Paul Cercueil <paul@crapouillou.net> wrote:
    > > Le jeu., juin 10 2021 at 15:58:51 +0300, Andy Shevchenko
    > > <andy.shevchenko@gmail.com> a écrit :
    > > > On Thu, Jun 10, 2021 at 3:47 PM Paul Cercueil <paul@crapouillou.net>
    > > > wrote:

    ...

    > > > I'm afraid, NAK. Otherwise, please put an explanation that clearly
    > > > shows that it will be no ABI breakage.
    > > > I.o.w. users for the existing drivers and devices will always get
    > > > those attributes at the same platform configuration(s).
    > >
    > > Well, the commit message says that I'm adding a mechanism to disable
    > > the feature. If it was actually doing anything else (like actually
    > > disabling it for any attribute) then I'd mention it in the commit
    > > message.
    > >
    > > I don't see how that possibly can be a ABI breakage.
    >
    > Ah. Both Andy and I got taken in by 'removing' in the title.

    Yep. I have read the patch first and my impression was that we are
    going to disable *existing* attributes, reading the complete series
    suggests it's not true. That's why I recommend to massage the commit
    message to avoid this confusion.

    > What you really mean is identifying the extended name. That's
    > much more acceptable :)


    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2021-06-10 15:16    [W:3.913 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site