lkml.org 
[lkml]   [2021]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/1] video: fbdev: sm501fb: use DEVICE_ATTR_RO macro
Date
Use DEVICE_ATTR_RO macro helper instead of plain DEVICE_ATTR, which makes
the code a bit shorter and easier to read.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/video/fbdev/sm501fb.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
index 6a52eba645596a4..d26afcfec4239aa 100644
--- a/drivers/video/fbdev/sm501fb.c
+++ b/drivers/video/fbdev/sm501fb.c
@@ -1238,8 +1238,8 @@ static int sm501fb_show_regs(struct sm501fb_info *info, char *ptr,
* show the crt control and cursor registers
*/

-static ssize_t sm501fb_debug_show_crt(struct device *dev,
- struct device_attribute *attr, char *buf)
+static ssize_t fbregs_crt_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
struct sm501fb_info *info = dev_get_drvdata(dev);
char *ptr = buf;
@@ -1250,15 +1250,15 @@ static ssize_t sm501fb_debug_show_crt(struct device *dev,
return ptr - buf;
}

-static DEVICE_ATTR(fbregs_crt, 0444, sm501fb_debug_show_crt, NULL);
+static DEVICE_ATTR_RO(fbregs_crt);

/* sm501fb_debug_show_pnl
*
* show the panel control and cursor registers
*/

-static ssize_t sm501fb_debug_show_pnl(struct device *dev,
- struct device_attribute *attr, char *buf)
+static ssize_t fbregs_pnl_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
struct sm501fb_info *info = dev_get_drvdata(dev);
char *ptr = buf;
@@ -1269,7 +1269,7 @@ static ssize_t sm501fb_debug_show_pnl(struct device *dev,
return ptr - buf;
}

-static DEVICE_ATTR(fbregs_pnl, 0444, sm501fb_debug_show_pnl, NULL);
+static DEVICE_ATTR_RO(fbregs_pnl);

static struct attribute *sm501fb_attrs[] = {
&dev_attr_crt_src.attr,
--
2.26.0.106.g9fadedd

\
 
 \ /
  Last update: 2021-06-02 04:30    [W:0.044 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site