lkml.org 
[lkml]   [2021]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH -next] x86/kprobes: functions should not be declared extern
Date
The function declaration in kprobes.h is already marked extern, thus its
definition should not have the keyword.

This quiets the following sparse warning:
function 'arch_unoptimize_kprobes' with external linkage has definition

Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
---
arch/x86/kernel/kprobes/opt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c
index 71425ebba98a..7d962c884505 100644
--- a/arch/x86/kernel/kprobes/opt.c
+++ b/arch/x86/kernel/kprobes/opt.c
@@ -539,8 +539,8 @@ void arch_unoptimize_kprobe(struct optimized_kprobe *op)
* Recover original instructions and breakpoints from relative jumps.
* Caller must call with locking kprobe_mutex.
*/
-extern void arch_unoptimize_kprobes(struct list_head *oplist,
- struct list_head *done_list)
+void arch_unoptimize_kprobes(struct list_head *oplist,
+ struct list_head *done_list)
{
struct optimized_kprobe *op, *tmp;

--
2.31.1
\
 
 \ /
  Last update: 2021-05-31 05:11    [W:0.042 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site