Messages in this thread | | | From | Joseph Richey <> | Date | Thu, 20 May 2021 04:50:11 -0700 | Subject | Re: [PATCH 0/6] Don't use BIT() macro in UAPI headers |
| |
> > Currently, the script actually _encourages_ users to use the BIT macro > > even if adding things to UAPI. > > How so?
Running checkpatch.pl with --strict gives:
CHECK: Prefer using the BIT macro #26: FILE: arch/x86/include/uapi/asm/hwcap2.h:9: +#define HWCAP2_FSGSBASE (1 << 1)
It should probably just recommend the _BITUL macro.
> Also, in your commit messages you refer to patches with patchwork links > - please use the respective upstream commit IDs instead. Grep for > "Fixes:" here:
Ahhhhh, I figured there was a more standard way. Will fix.
| |