Messages in this thread Patch in this message | | | From | Jiapeng Chong <> | Subject | [PATCH] net: netrom: nr_in: Remove redundant assignment to ns | Date | Wed, 28 Apr 2021 17:58:05 +0800 |
| |
Variable ns is set to 'skb->data[17]' but this value is never read as it is overwritten or not used later on, hence it is a redundant assignment and can be removed.
Cleans up the following clang-analyzer warning:
net/netrom/nr_in.c:156:2: warning: Value stored to 'ns' is never read [clang-analyzer-deadcode.DeadStores].
Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- net/netrom/nr_in.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/net/netrom/nr_in.c b/net/netrom/nr_in.c index 69e5890..2f084b6 100644 --- a/net/netrom/nr_in.c +++ b/net/netrom/nr_in.c @@ -153,7 +153,6 @@ static int nr_state3_machine(struct sock *sk, struct sk_buff *skb, int frametype int queued = 0; nr = skb->data[18]; - ns = skb->data[17]; switch (frametype) { case NR_CONNREQ: -- 1.8.3.1
| |