Messages in this thread Patch in this message | | | From | Wan Jiabing <> | Subject | [PATCH] ocfs2: Remove repeated uptodate check for buffer | Date | Sun, 25 Apr 2021 10:57:02 +0800 |
| |
In commit 60f91826ca62 ("buffer: Avoid setting buffer bits that are already set"), function set_buffer_##name was added a test_bit() to check buffer, which is the same as function buffer_##name. The !buffer_uptodate(bh) here is a repeated check. Remove it.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> --- fs/ocfs2/aops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index ad20403b383f..bd039fdbb27e 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c @@ -634,8 +634,7 @@ int ocfs2_map_page_blocks(struct page *page, u64 *p_blkno, } if (PageUptodate(page)) { - if (!buffer_uptodate(bh)) - set_buffer_uptodate(bh); + set_buffer_uptodate(bh); } else if (!buffer_uptodate(bh) && !buffer_delay(bh) && !buffer_new(bh) && ocfs2_should_read_blk(inode, page, block_start) && -- 2.25.1
| |