lkml.org 
[lkml]   [2021]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support
Hi,

On Sat, Apr 10, 2021 at 08:52:22PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> one more comment:
>
> On Sat, Apr 10, 2021 at 08:08:37AM +0900, Nobuhiro Iwamatsu wrote:
> > +static inline struct visconti_pwm_chip *to_visconti_chip(struct pwm_chip *chip)
>
> all functions but this one start have the common prefix "visconti_pwm_".
> I like the concept of a common prefix and so you could rename this
> function to visconti_pwm_from_chip or similar.

OK, I will change.

>
> Best regards
> Uwe
>

Best regards,
Nobuhiro

\
 
 \ /
  Last update: 2021-04-12 05:06    [W:0.101 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site