Messages in this thread | | | Date | Sat, 10 Apr 2021 20:52:22 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v4 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support |
| |
Hello,
one more comment:
On Sat, Apr 10, 2021 at 08:08:37AM +0900, Nobuhiro Iwamatsu wrote: > +static inline struct visconti_pwm_chip *to_visconti_chip(struct pwm_chip *chip)
all functions but this one start have the common prefix "visconti_pwm_". I like the concept of a common prefix and so you could rename this function to visconti_pwm_from_chip or similar.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |