lkml.org 
[lkml]   [2021]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/3] input: gpio-keys: Remove extra call to input_sync
Date
The input_sync() function will already be called within
gpio_keys_gpio_report_event(), so there's no need to call it again after
the loop in gpio_keys_report_state().

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
drivers/input/keyboard/gpio_keys.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index 77bac4ddf324..0be204693ab0 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -641,7 +641,6 @@ static int gpio_keys_setup_key(struct platform_device *pdev,

static void gpio_keys_report_state(struct gpio_keys_drvdata *ddata)
{
- struct input_dev *input = ddata->input;
int i;

for (i = 0; i < ddata->pdata->nbuttons; i++) {
@@ -649,7 +648,6 @@ static void gpio_keys_report_state(struct gpio_keys_drvdata *ddata)
if (bdata->gpiod)
gpio_keys_gpio_report_event(bdata);
}
- input_sync(input);
}

static int gpio_keys_open(struct input_dev *input)
--
2.30.1
\
 
 \ /
  Last update: 2021-03-05 18:03    [W:0.068 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site