lkml.org 
[lkml]   [2021]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[BUG] fs/notify/mark: A potential use after free in fsnotify_put_mark_wake
Hi,
My static analyzer tool reported a use after free in fsnotify_put_mark_wake
of the file: fs/notify/mark.c.

In fsnotify_put_mark_wake, it calls fsnotify_put_mark(mark). Inside the function
fsnotify_put_mark(), if conn is NULL, it will call fsnotify_final_mark_destroy(mark)
to free mark->group by fsnotify_put_group(group) and return. I also had inspected
the implementation of fsnotify_put_group() and found that there is no cleanup operation
about group->user_waits.

But after fsnotify_put_mark_wake() returned, mark->group is still used by
if (atomic_dec_and_test(&group->user_waits) && group->shutdown) and later.

Is this an issue?

Thanks.





\
 
 \ /
  Last update: 2021-03-28 11:13    [W:0.286 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site