Messages in this thread Patch in this message | | | Date | Sun, 28 Mar 2021 16:54:45 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH] ASoC: cygnus: fix for_each_child.cocci warnings |
| |
From: kernel test robot <lkp@intel.com>
Function "for_each_available_child_of_node" should have of_node_put() before return around line 1352.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Sumera Priyadarsini <sylphrenadin@gmail.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> Signed-off-by: Julia Lawall <julia.lawall@inria.fr> ---
cygnus-ssp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
--- a/sound/soc/bcm/cygnus-ssp.c +++ b/sound/soc/bcm/cygnus-ssp.c @@ -1348,8 +1348,10 @@ static int cygnus_ssp_probe(struct platf &cygnus_ssp_dai[active_port_count]);
/* negative is err, 0 is active and good, 1 is disabled */ - if (err < 0) + if (err < 0) { + of_node_put(child_node); return err; + } else if (!err) { dev_dbg(dev, "Activating DAI: %s\n", cygnus_ssp_dai[active_port_count].name);
| |