Messages in this thread | | | Subject | Re: [RFC PATCH v3 3/3] blk-mq: Lockout tagset iterator when exiting elevator | From | Bart Van Assche <> | Date | Wed, 10 Mar 2021 08:00:14 -0800 |
| |
On 3/10/21 12:52 AM, John Garry wrote: > On 09/03/2021 19:21, Bart Van Assche wrote: >> Regarding this patch series, I have shared the feedback I wanted to >> share so I would appreciate it if someone else could also take a look. > > So I can incorporate any changes and suggestions so far and send a > non-RFC version - that may get more attention if none extra comes. > > As mentioned on the cover letter, if patch 2+3/3 are accepted, then > patch 1/3 could be simplified. But I plan to leave as is. > > BTW, any issue with putting your suggested-by on patch 2/3?
Hi John,
I have added my Reviewed-by to patch 2/3.
Regarding the other two patches in this series: I do not agree with patch 3/3. As I have explained, I am concerned that that patch breaks existing block drivers.
Are patches 1/3 and 3/3 necessary? Or in other words, is patch 2/3 sufficient to fix the use-after-free?
Thanks,
Bart.
| |