Messages in this thread | | | Subject | Re: [RFC PATCH v3 3/3] blk-mq: Lockout tagset iterator when exiting elevator | From | Bart Van Assche <> | Date | Tue, 9 Mar 2021 11:21:41 -0800 |
| |
On 3/9/21 9:47 AM, John Garry wrote: > This does fall over if some tags are allocated without associated > request queue, which I do not know exists.
The only tag allocation mechanism I know of is blk_mq_get_tag(). The only blk_mq_get_tag() callers I know of are __blk_mq_alloc_request() and blk_mq_alloc_request_hctx(). So I think all allocated tags are associated with a request queue.
Regarding this patch series, I have shared the feedback I wanted to share so I would appreciate it if someone else could also take a look.
Thanks,
Bart.
| |