lkml.org 
[lkml]   [2021]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] net: socket.c: Fix comparison issues
The constant has been placed to the right side of the test.

Signed-off-by: Shubhankar Kuranagatti <shubhankarvk@gmail.com>
---
net/socket.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/socket.c b/net/socket.c
index 84a8049c2b09..a23dd4348793 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -1495,7 +1495,7 @@ int __sys_socket(int family, int type, int protocol)
return -EINVAL;
type &= SOCK_TYPE_MASK;

- if (SOCK_NONBLOCK != O_NONBLOCK && (flags & SOCK_NONBLOCK))
+ if ((flags & SOCK_NONBLOCK) && SOCK_NONBLOCK != O_NONBLOCK)
flags = (flags & ~SOCK_NONBLOCK) | O_NONBLOCK;

retval = sock_create(family, type, protocol, &sock);
@@ -1526,7 +1526,7 @@ int __sys_socketpair(int family, int type, int protocol, int __user *usockvec)
return -EINVAL;
type &= SOCK_TYPE_MASK;

- if (SOCK_NONBLOCK != O_NONBLOCK && (flags & SOCK_NONBLOCK))
+ if ((flags & SOCK_NONBLOCK) && SOCK_NONBLOCK != O_NONBLOCK)
flags = (flags & ~SOCK_NONBLOCK) | O_NONBLOCK;

/*
@@ -1693,7 +1693,7 @@ int __sys_accept4_file(struct file *file, unsigned file_flags,
if (flags & ~(SOCK_CLOEXEC | SOCK_NONBLOCK))
return -EINVAL;

- if (SOCK_NONBLOCK != O_NONBLOCK && (flags & SOCK_NONBLOCK))
+ if ((flags & SOCK_NONBLOCK) && SOCK_NONBLOCK != O_NONBLOCK)
flags = (flags & ~SOCK_NONBLOCK) | O_NONBLOCK;

sock = sock_from_file(file);
--
2.17.1
\
 
 \ /
  Last update: 2021-03-11 05:45    [W:0.042 / U:1.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site