[lkml]   [2021]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 05/18] tty: serial: samsung_tty: add support for Apple UARTs
On 09/02/2021 01.46, Greg Kroah-Hartman wrote:
> I HATE adding new PORT_ types, as I am almost positive no one uses them,
> but as they are in the uapi files, we can't delete them.
> So, just use an existing one, why do you want a new one? If you don't
> have a userspace tool that requires it, don't bother.
> Just use PORT_8250 and be done with it. I should force all new drivers
> to use that as well :)

Krzysztof: given this, I think it would be fair to add an enum to the
driver to keep track of the actual hardware type (grouped into probably
just 3, S3C24XX, S3C6400, APPLE), get rid of any code in there that
cares about the uapi-visible port type (other than setting it correctly
for those that do exist, to maintain current behavior), and just make
everything else use PORT_8250 for that?

Hector Martin (
Public Key:

 \ /
  Last update: 2021-02-09 00:24    [W:0.235 / U:2.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site