Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register | Date | Thu, 25 Feb 2021 09:09:30 +0200 |
| |
<Ajay.Kathat@microchip.com> writes:
> On 24/02/21 10:13 pm, Kalle Valo wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you >> know the content is safe >> >> Marcus Folkesson <marcus.folkesson@gmail.com> writes: >> >>> Write the value instead of reading it twice. >>> >>> Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in wilc_sdio.c file") >>> >>> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> >>> --- >>> drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c >>> index 351ff909ab1c..e14b9fc2c67a 100644 >>> --- a/drivers/net/wireless/microchip/wilc1000/sdio.c >>> +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c >>> @@ -947,7 +947,7 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int nint) >>> for (i = 0; (i < 3) && (nint > 0); i++, nint--) >>> reg |= BIT(i); >>> >>> - ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, ®); >>> + ret = wilc_sdio_write_reg(wilc, WILC_INTR2_ENABLE, reg); >> >> To me it looks like the bug existed before commit 5e63a598441a: > > > Yes, you are correct. The bug existed from commit c5c77ba18ea6: > > https://git.kernel.org/linus/c5c77ba18ea6
So the fixes tag should be:
Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
I can change that during commit, ok?
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |