Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register | Date | Wed, 24 Feb 2021 18:43:59 +0200 |
| |
Marcus Folkesson <marcus.folkesson@gmail.com> writes:
> Write the value instead of reading it twice. > > Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in wilc_sdio.c file") > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> > --- > drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c > index 351ff909ab1c..e14b9fc2c67a 100644 > --- a/drivers/net/wireless/microchip/wilc1000/sdio.c > +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c > @@ -947,7 +947,7 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int nint) > for (i = 0; (i < 3) && (nint > 0); i++, nint--) > reg |= BIT(i); > > - ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, ®); > + ret = wilc_sdio_write_reg(wilc, WILC_INTR2_ENABLE, reg);
To me it looks like the bug existed before commit 5e63a598441a:
- ret = sdio_read_reg(wilc, WILC_INTR2_ENABLE, ®); + ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, ®);
https://git.kernel.org/linus/5e63a598441a
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |