Messages in this thread Patch in this message | | | Date | Tue, 2 Feb 2021 08:47:39 +0300 | From | Dan Carpenter <> | Subject | [PATCH] ceph: Fix an Oops in error handling |
| |
The "req" pointer is an error pointer and not NULL so this check needs to be fixed.
Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- fs/ceph/addr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 5eec6f66fe52..fb0238a4d34f 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -273,7 +273,7 @@ static void ceph_netfs_issue_op(struct netfs_read_subrequest *subreq) if (err) iput(inode); out: - if (req) + if (!IS_ERR_OR_NULL(req)) ceph_osdc_put_request(req); if (err) netfs_subreq_terminated(subreq, err); -- 2.29.2
| |