Messages in this thread | | | Date | Thu, 2 Dec 2021 20:29:06 +0530 | From | Manivannan Sadhasivam <> | Subject | Re: [PATCH v2 15/20] media: imx290: mark read reg function as __always_unused |
| |
Hi Mauro,
On Mon, Nov 29, 2021 at 10:47:47AM +0100, Mauro Carvalho Chehab wrote: > Such function is currently unused, but could be needed in the > future. So, keep it, marking it as __always_unused, in order to > avoid a clang W=1 error. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > > See [PATCH v2 00/20] at: https://lore.kernel.org/all/cover.1638179135.git.mchehab+huawei@kernel.org/ > > drivers/media/i2c/imx290.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c > index bf7a6c37ca5d..99f2a50d39a4 100644 > --- a/drivers/media/i2c/imx290.c > +++ b/drivers/media/i2c/imx290.c > @@ -363,7 +363,7 @@ static inline struct imx290 *to_imx290(struct v4l2_subdev *_sd) > return container_of(_sd, struct imx290, sd); > } > > -static inline int imx290_read_reg(struct imx290 *imx290, u16 addr, u8 *value) > +static inline int __always_unused imx290_read_reg(struct imx290 *imx290, u16 addr, u8 *value)
Can we drop this function instead?
Thanks, Mani
> { > unsigned int regval; > int ret; > -- > 2.33.1 >
| |