lkml.org 
[lkml]   [2021]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 03/20] media: davinci: get rid of an unused function
    On Mon, Nov 29, 2021 at 9:47 AM Mauro Carvalho Chehab
    <mchehab+huawei@kernel.org> wrote:
    >
    > vpif_get_default_field() seems to be some left-over from a
    > past code that sets the field order.
    >
    > Reviewed-by: Nathan Chancellor <nathan@kernel.org>
    > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    > ---
    >
    > See [PATCH v2 00/20] at: https://lore.kernel.org/all/cover.1638179135.git.mchehab+huawei@kernel.org/
    >
    > drivers/media/platform/davinci/vpif_capture.c | 11 -----------
    > 1 file changed, 11 deletions(-)
    >
    Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>

    Cheers,
    Prabhakar

    > diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c
    > index ae92e2c206d0..aba105fa7ef9 100644
    > --- a/drivers/media/platform/davinci/vpif_capture.c
    > +++ b/drivers/media/platform/davinci/vpif_capture.c
    > @@ -618,17 +618,6 @@ static void vpif_calculate_offsets(struct channel_obj *ch)
    > ch->vpifparams.video_params.stdid = vpifparams->std_info.stdid;
    > }
    >
    > -/**
    > - * vpif_get_default_field() - Get default field type based on interface
    > - * @iface: ptr to vpif interface
    > - */
    > -static inline enum v4l2_field vpif_get_default_field(
    > - struct vpif_interface *iface)
    > -{
    > - return (iface->if_type == VPIF_IF_RAW_BAYER) ? V4L2_FIELD_NONE :
    > - V4L2_FIELD_INTERLACED;
    > -}
    > -
    > /**
    > * vpif_config_addr() - function to configure buffer address in vpif
    > * @ch: channel ptr
    > --
    > 2.33.1
    >

    \
     
     \ /
      Last update: 2021-11-29 12:04    [W:5.518 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site