Messages in this thread Patch in this message | | | From | Guenter Roeck <> | Subject | [PATCH] fs: ntfs: Mark NTFS_RW as BROKEN for PPC | Date | Mon, 22 Nov 2021 12:13:52 -0800 |
| |
NTFS_RW code allocates page size dependent arrays on the stack. This results in build failures if the page size is 64k, which is now the default for PPC.
fs/ntfs/aops.c: In function 'ntfs_write_mst_block': fs/ntfs/aops.c:1311:1: error: the frame size of 2240 bytes is larger than 2048 bytes
Increasing the maximum frame size for PPC just to silence this error does not really help. It would have to be set to a really large value for 256k pages. Such a large frame size could potentially result in stack overruns in this code and elsewhere and is therefore not desirable. Mark NTFS_RW as broken for PPC instead.
Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- The Kconfig language does not support "depends on XXX if YYY", so this is the next best choice.
fs/ntfs/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/fs/ntfs/Kconfig b/fs/ntfs/Kconfig index 1667a7e590d8..094ddef6010a 100644 --- a/fs/ntfs/Kconfig +++ b/fs/ntfs/Kconfig @@ -51,6 +51,7 @@ config NTFS_DEBUG config NTFS_RW bool "NTFS write support" + depends on BROKEN || !PPC depends on NTFS_FS help This enables the partial, but safe, write support in the NTFS driver. -- 2.33.0
| |