lkml.org 
[lkml]   [2021]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] USB: array-index-out-of-bounds in ehci_brcm_hub_control
Date
There isn't enough check parameter `wIndex` in the function 
`ehci_brcm_hub_control`;due to the size of array `port_status`
is 15, so it may lead to out of bounds.

Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
Reported-by: TCS Robot <tcs_robot@tencent.com>
---
drivers/usb/host/ehci-brcm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-brcm.c b/drivers/usb/host/ehci-brcm.c
index d3626bfa966b..4ca3eb9fcda9 100644
--- a/drivers/usb/host/ehci-brcm.c
+++ b/drivers/usb/host/ehci-brcm.c
@@ -63,7 +63,8 @@ static int ehci_brcm_hub_control(
unsigned long flags;
int retval, irq_disabled = 0;

- status_reg = &ehci->regs->port_status[(wIndex & 0xff) - 1];
+ if (wIndex && wIndex <= ports)
+ status_reg = &ehci->regs->port_status[(wIndex & 0xff) - 1];

/*
* RESUME is cleared when GetPortStatus() is called 20ms after start
--
\
 
 \ /
  Last update: 2021-11-02 08:47    [W:0.029 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site