Messages in this thread | | | Date | Mon, 18 Oct 2021 23:59:41 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v10 03/11] x86/cpufeatures: Add TDX Guest CPU feature |
| |
On Mon, Oct 18, 2021 at 02:05:10PM -0700, Sathyanarayanan Kuppuswamy wrote: > Any consensus on this?
Well, you can simply not put any comment there now because this patchset doesn't add those debug options.
The patch which adds them, should add that comment explaining why that order needs to be the way it is.
In general, I get the impression from review that you add stuff for future patchsets which only confuses reviewers and instead, you should simply not do that but do only the required changes, only for the current aspect of functionality being added.
> I think SME code also talks about future use case in its comment.
No, this has nothing to do with a future use case: you should look at what that function does and then read that comment again.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |