[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v10 03/11] x86/cpufeatures: Add TDX Guest CPU feature

On 10/18/21 2:59 PM, Borislav Petkov wrote:
> On Mon, Oct 18, 2021 at 02:05:10PM -0700, Sathyanarayanan Kuppuswamy wrote:
>> Any consensus on this?
> Well, you can simply not put any comment there now because this patchset
> doesn't add those debug options.
> The patch which adds them, should add that comment explaining why that
> order needs to be the way it is.

For now I will remove the comment as you have suggested.

> In general, I get the impression from review that you add stuff for
> future patchsets which only confuses reviewers and instead, you should
> simply not do that but do only the required changes, only for the
> current aspect of functionality being added.

I will check the patch list again and re-organize the patch set, If I
find any such changes.

>> I think SME code also talks about future use case in its comment.
> No, this has nothing to do with a future use case: you should look at
> what that function does and then read that comment again.

Sorry, I will check the details correctly.

Sathyanarayanan Kuppuswamy
Linux Kernel Developer

 \ /
  Last update: 2021-10-19 00:05    [W:0.150 / U:3.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site