lkml.org 
[lkml]   [2021]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] x86/vector: Add missing annotation for void lock_vector_lock() and unlock_vector_lock()
Date
Sparse reports a warning at lock_vector_lock() and unlock_vector_lock()

The root cause is the missing annotations at lock_vector_lock() and unlock_vector_lock()

Add the missing __acquires(&vector_lock)
Add the missing __releases(&vector_lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
arch/x86/kernel/apic/vector.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
index c132daabe615..c824c346e501 100644
--- a/arch/x86/kernel/apic/vector.c
+++ b/arch/x86/kernel/apic/vector.c
@@ -48,6 +48,7 @@ static DEFINE_PER_CPU(struct hlist_head, cleanup_list);
#endif

void lock_vector_lock(void)
+ __acquires(&vector_lock)
{
/* Used to the online set of cpus does not change
* during assign_irq_vector.
@@ -56,6 +57,7 @@ void lock_vector_lock(void)
}

void unlock_vector_lock(void)
+ __releases(&vector_lock)
{
raw_spin_unlock(&vector_lock);
}
--
2.32.0
\
 
 \ /
  Last update: 2021-10-02 01:15    [W:0.036 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site