lkml.org 
[lkml]   [2021]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/3] Add missing vdd-supply for QUSB2 PHY
Hi Shawn,

On 28-09-21, 10:19, Shawn Guo wrote:
> The series adds missing vdd-supply for QUSB2 PHY which is required for
> digital circuit. The driver works right now likely because firmware
> already sets it up. Add it to bindings, driver and DTS that miss the
> supply.
>
> It should not cause problem for existing DTBs:
> - SC7180, SDM630, SDM845 based platforms already specified vdd-supply
> in the DTBs.
> - MSM8996 and MSM8998 platform DTBs miss vdd-supply, but dummy regulator
> will ensure QUSB2 PHY driver works as before on these platforms.

What about the rest.. I checked SM8350 and SM8250 mtp ones are missing
this. With the property made mandatory, I guess it would cause these to
fail right..

>
> Changes for v2:
> - Correct copy & paste error on vdd-supply name in bindings doc.
>
>
> Shawn Guo (3):
> dt-bindings: phy: qcom,qusb2: Add missing vdd-supply
> phy: qcom-qusb2: Add missing vdd supply
> arm64: dts: qcom: Add missing vdd-supply for QUSB2 PHY
>
> Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 6 ++++++
> arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 2 ++
> arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi | 1 +
> arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi | 1 +
> arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi | 1 +
> drivers/phy/qualcomm/phy-qcom-qusb2.c | 2 +-
> 6 files changed, 12 insertions(+), 1 deletion(-)
>
> --
> 2.17.1

--
~Vinod

\
 
 \ /
  Last update: 2021-10-01 10:17    [W:0.108 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site