Messages in this thread | | | Date | Wed, 23 Sep 2020 18:09:07 -0700 (PDT) | Subject | Re: [PATCH v1 net] net: stmmac: removed enabling eee in EEE set callback | From | David Miller <> |
| |
From: Voon Weifeng <weifeng.voon@intel.com> Date: Wed, 23 Sep 2020 16:56:14 +0800
> EEE should be only be enabled during stmmac_mac_link_up() when the > link are up and being set up properly. set_eee should only do settings > configuration and disabling the eee. > > Without this fix, turning on EEE using ethtool will return > "Operation not supported". This is due to the driver is in a dead loop > waiting for eee to be advertised in the for eee to be activated but the > driver will only configure the EEE advertisement after the eee is > activated. > > Ethtool should only return "Operation not supported" if there is no EEE > capbility in the MAC controller. > > Fixes: 8a7493e58ad6 ("net: stmmac: Fix a race in EEE enable callback") > > Signed-off-by: Voon Weifeng <weifeng.voon@intel.com>
Please do not insert empty lines between Fixes: and other tags. All tags are equal and belong together in a group.
I fixed that up, applied the patch, and queued it up for -stable.
Thank you.
| |