Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH][next] PCI: brcmstb: fix a missing if statement on a return error check | Date | Mon, 21 Sep 2020 15:40:17 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
The error return ret is not being check with an if statement and currently the code always returns leaving the following code as dead code. Fix this by adding in the missing if statement.
Addresses-Coverity: ("Structurally dead code") Fixes: ad3d29c77e1e ("PCI: brcmstb: Add control of rescal reset") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/pci/controller/pcie-brcmstb.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 7a3ff4632e7c..cb0c11b7308e 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1154,6 +1154,7 @@ static int brcm_pcie_resume(struct device *dev) clk_prepare_enable(pcie->clk); ret = brcm_phy_start(pcie); + if (ret) return ret; /* Take bridge out of reset so we can access the SERDES reg */ -- 2.27.0
| |