Messages in this thread | | | From | Rob Clark <> | Date | Mon, 21 Sep 2020 11:33:21 -0700 | Subject | Re: [PATCH] iommu/qcom: add missing put_device() call in qcom_iommu_of_xlate() |
| |
On Mon, Sep 21, 2020 at 11:27 AM Rob Clark <robdclark@gmail.com> wrote: > > On Mon, Sep 21, 2020 at 10:50 AM Will Deacon <will@kernel.org> wrote: > > > > On Fri, Sep 18, 2020 at 09:13:57AM +0800, Yu Kuai wrote: > > > if of_find_device_by_node() succeed, qcom_iommu_of_xlate() doesn't have > > > a corresponding put_device(). Thus add put_device() to fix the exception > > > handling for this function implementation. > > > > > > Fixes: e86d1aa8b60f ("iommu/arm-smmu: Move Arm SMMU drivers into their own subdirectory") > > > > That's probably not accurate, in that this driver used to live under > > drivers/iommu/ and assumedly had this bug there as well. > >
and fwiw, that looks like it should be:
Fixes: 0ae349a0f33fb ("iommu/qcom: Add qcom_iommu")
> > > Signed-off-by: Yu Kuai <yukuai3@huawei.com> > > > --- > > > drivers/iommu/arm/arm-smmu/qcom_iommu.c | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > I guess Rob will pick this up. > > Probably overkill for me to send a pull req for a single patch, if you > want to pick it up: > > Acked-by: Rob Clark <robdclark@gmail.com>
| |