Messages in this thread | | | Date | Mon, 21 Sep 2020 18:50:49 +0100 | From | Will Deacon <> | Subject | Re: [PATCH] iommu/qcom: add missing put_device() call in qcom_iommu_of_xlate() |
| |
On Fri, Sep 18, 2020 at 09:13:57AM +0800, Yu Kuai wrote: > if of_find_device_by_node() succeed, qcom_iommu_of_xlate() doesn't have > a corresponding put_device(). Thus add put_device() to fix the exception > handling for this function implementation. > > Fixes: e86d1aa8b60f ("iommu/arm-smmu: Move Arm SMMU drivers into their own subdirectory")
That's probably not accurate, in that this driver used to live under drivers/iommu/ and assumedly had this bug there as well.
> Signed-off-by: Yu Kuai <yukuai3@huawei.com> > --- > drivers/iommu/arm/arm-smmu/qcom_iommu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-)
I guess Rob will pick this up.
Will
| |