Messages in this thread | | | Subject | Re: [PATCHv4 6/6] iommu: arm-smmu-impl: Remove unwanted extra blank lines | From | Robin Murphy <> | Date | Fri, 11 Sep 2020 17:03:06 +0100 |
| |
On 2020-09-11 15:28, Sai Prakash Ranjan wrote: > There are few places in arm-smmu-impl where there are > extra blank lines, remove them
FWIW those were deliberate - sometimes I like a bit of subtle space to visually delineate distinct groups of definitions. I suppose it won't be to everyone's taste :/
> and while at it fix the > checkpatch warning for space required before the open > parenthesis.
That one, however, was not ;)
BTW am I supposed to have received 3 copies of everything? Because I did...
Robin.
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > --- > drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c b/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c > index ce78295cfa78..f5b5218cbe5b 100644 > --- a/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c > @@ -19,7 +19,7 @@ static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = { > > static int arm_smmu_gr0_ns(int offset) > { > - switch(offset) { > + switch (offset) { > case ARM_SMMU_GR0_sCR0: > case ARM_SMMU_GR0_sACR: > case ARM_SMMU_GR0_sGFSR: > @@ -54,7 +54,6 @@ static const struct arm_smmu_impl calxeda_impl = { > .write_reg = arm_smmu_write_ns, > }; > > - > struct cavium_smmu { > struct arm_smmu_device smmu; > u32 id_base; > @@ -110,7 +109,6 @@ static struct arm_smmu_device *cavium_smmu_impl_init(struct arm_smmu_device *smm > return &cs->smmu; > } > > - > #define ARM_MMU500_ACTLR_CPRE (1 << 1) > > #define ARM_MMU500_ACR_CACHE_LOCK (1 << 26) > @@ -197,7 +195,6 @@ static const struct arm_smmu_impl mrvl_mmu500_impl = { > .reset = arm_mmu500_reset, > }; > > - > struct arm_smmu_device *arm_smmu_impl_init(struct arm_smmu_device *smmu) > { > const struct device_node *np = smmu->dev->of_node; >
| |