Messages in this thread Patch in this message | | | From | Tetsuo Handa <> | Subject | [PATCH] checkpatch: accept longer commit description lines | Date | Thu, 10 Sep 2020 23:32:08 +0900 |
| |
Given that commit bdc48fa11e46f867 ("checkpatch/coding-style: deprecate 80-column warning") was introduced because nowadays most of us are using screens that can print more than 100 columns, most of us will be also using mail clients that can print more than 100 columns. Since 75 chars limit for commit description lines is sometimes inconvenient for obeying 'commit <12+ chars of sha1> ("<title line>")' style or embedding URLs, loosen the limit by 20 chars.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> --- scripts/checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 504d2e431c60..bebeef90fc61 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2800,9 +2800,9 @@ sub process { $commit_log_possible_stack_dump = 1; } -# Check for line lengths > 75 in commit log, warn once +# Check for line lengths > 95 in commit log, warn once if ($in_commit_log && !$commit_log_long_line && - length($line) > 75 && + length($line) > 95 && !($line =~ /^\s*[a-zA-Z0-9_\/\.]+\s+\|\s+\d+/ || # file delta changes $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ || @@ -2811,7 +2811,7 @@ sub process { # A Fixes: or Link: line $commit_log_possible_stack_dump)) { WARN("COMMIT_LOG_LONG_LINE", - "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr); + "Possible unwrapped commit description (prefer a maximum 95 chars per line)\n" . $herecurr); $commit_log_long_line = 1; } -- 2.18.4
| |