lkml.org 
[lkml]   [2020]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] bus: arm: Add of_node_put() before break statement
Every iteration of for_each_available_child_of_node() decrements the
reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a
return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.

Fix a potential memory leak in arm-cci.c by inserting
of_node_put() before a break statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
---
drivers/bus/arm-cci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index b8184a903583..1f84a5528073 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np)

i = nb_ace + nb_ace_lite;

- if (i >= nb_cci_ports)
+ if (i >= nb_cci_ports) {
+ of_node_put(cp);
break;
+ }

if (of_property_read_string(cp, "interface-type",
&match_str)) {
--
2.17.1
\
 
 \ /
  Last update: 2020-08-31 05:11    [W:0.025 / U:1.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site