Messages in this thread | | | Subject | Re: [PATCH 2/2] dt-bindings: leds: Add bindings for MT6360 LED | From | Dan Murphy <> | Date | Wed, 26 Aug 2020 06:54:16 -0500 |
| |
Gene
On 8/26/20 6:37 AM, Gene Chen wrote: > From: Gene Chen <gene_chen@richtek.com> > > Add bindings document for LED support on MT6360 PMIC
Usually bindings are 1/x in the patchset.
And you should cc Rob Herring and the Device tree mail list other wise the maintainer will not apply this patch without their ACKs
> Signed-off-by: Gene Chen <gene_chen@richtek.com> > --- > .../devicetree/bindings/leds/leds-mt6360.yaml | 50 ++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml > > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml > new file mode 100644 > index 0000000..4598be5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LED driver for MT6360 PMIC from MediaTek Integrated. > + > +maintainers: > + - Gene Chen <gene_chen@richtek.com> > + > +description: | > + This module is part of the MT6360 MFD device. For more details > + see Documentation/devicetree/bindings/mfd/mt6360.yaml.
I think you need to include this yaml using allof tag
> + > + The LED controller is represented as a sub-node of the PMIC node on > + the device tree. > + > + This device has six current sinks. > + > +properties: > + compatible: > + const: mediatek,mt6360-led > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^led@[0-5]$": > + type: object > + description: | > + Properties for a single LED. > + > + properties: > + reg: > + description: > + Index of the LED. > + minimum: 0 > + maximum: 5 > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > +additionalProperties: false > + Need a new line
And an example
> +...
| |