lkml.org 
[lkml]   [2020]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] leds: mt6360: Add LED driver for MT6360
Hi!
>
> >@@ -271,6 +271,17 @@ config LEDS_MT6323
> > This option enables support for on-chip LED drivers found on
> > Mediatek MT6323 PMIC.


...522 lines...

> >+static int mt6360_init_isnk_properties(struct mt6360_led *led, struct led_init_data *init_data)
> >+{
> >+ struct led_classdev *isnk = &led->isnk;
> >+
> >+ isnk->max_brightness = mt6360_get_isnk_max_level(led->led_no);

> This function is called once seems a bit much to have a service function for
> a simple switch case.

Please remove code you are not commenting on. That a) reduces
bandwidth requirements but more importantly b) makes it easier to find
your comments.

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-09-09 10:47    [W:0.110 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site