Messages in this thread | | | Date | Tue, 2 Jun 2020 12:32:41 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v4 4/5] regulator: qcom: Add labibb driver |
| |
On Tue, Jun 02, 2020 at 03:39:23PM +0530, Sumit Semwal wrote:
> +static int qcom_labibb_regulator_is_enabled(struct regulator_dev *rdev) > +{ > + int ret; > + unsigned int val; > + struct labibb_regulator *reg = rdev_get_drvdata(rdev); > + > + ret = regmap_read(reg->regmap, reg->base + REG_LABIBB_STATUS1, &val); > + if (ret < 0) { > + dev_err(reg->dev, "Read register failed ret = %d\n", ret); > + return ret; > + } > + return !!(val & LABIBB_STATUS1_VREG_OK_BIT); > +}
This should be a get_status() callback...
> +static int qcom_labibb_regulator_enable(struct regulator_dev *rdev) > +{ > + return regulator_enable_regmap(rdev); > +} > + > +static int qcom_labibb_regulator_disable(struct regulator_dev *rdev) > +{ > + return regulator_disable_regmap(rdev); > +}
...is_enabled() should just be regulator_is_enabled_regmap() and these functions should just be removed entirely, you can use the regmap operations directly as the ops without the wrapper.
> + match = of_match_device(qcom_labibb_match, &pdev->dev); > + if (!match) > + return -ENODEV; > + > + for (reg_data = match->data; reg_data->name; reg_data++) { > + child = of_get_child_by_name(pdev->dev.of_node, reg_data->name); > + > + if (WARN_ON(child == NULL)) > + return -EINVAL;
This feels like the DT bindings are confused - why do we need to search like this?
> + dev_info(dev, "Registering %s regulator\n", child->full_name);
This is noise, remove it. The regulator framework will announce new regulators anyway. [unhandled content-type:application/pgp-signature] | |