lkml.org 
[lkml]   [2020]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] power: reset: ltc2952: remove set variable but unused value
From
Date
> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/power/reset/ltc2952-poweroff.c:97:16: warning: variable
> ‘overruns’ set but not used [-Wunused-but-set-variable]

I suggest to improve also this commit message.

* Can it be helpful to replace the word “Fixes” by the text
“An issue was pointed out by the compiler.”?

* How do you think about to add the wording “Thus delete the mentioned variable.”
to the change description?

* The value of an assigned variable was not reused in this function implementation.
Should this detail be better represented in the final commit subject?

* Would you like to add the tag “Fixes”?

Regards,
Markus

\
 
 \ /
  Last update: 2020-05-09 09:03    [W:0.030 / U:2.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site