Messages in this thread | | | Subject | Re: [PATCH] power: reset: ltc2952: remove set variable but unused value | From | Markus Elfring <> | Date | Sat, 9 May 2020 09:02:47 +0200 |
| |
> Fixes gcc '-Wunused-but-set-variable' warning: > drivers/power/reset/ltc2952-poweroff.c:97:16: warning: variable > ‘overruns’ set but not used [-Wunused-but-set-variable]
I suggest to improve also this commit message.
* Can it be helpful to replace the word “Fixes” by the text “An issue was pointed out by the compiler.”?
* How do you think about to add the wording “Thus delete the mentioned variable.” to the change description?
* The value of an assigned variable was not reused in this function implementation. Should this detail be better represented in the final commit subject?
* Would you like to add the tag “Fixes”?
Regards, Markus
| |