[lkml]   [2020]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")
On Sat, May 30, 2020 at 08:14:34AM +0100, Matthew Garrett wrote:
> On Sat, May 30, 2020 at 08:33:50AM +0200, Heiner Kallweit wrote:
> > It *was* default y. This changed with a914ff2d78ce ("PCI/ASPM: Don't
> > select CONFIG_PCIEASPM by default") and that's what triggered the
> > problem. If there's no easy solution, then maybe it's best to revert
> > the change for now.
> Oh, sorry, I was looking at mainline. CONFIG_PCIEASPM should
> *definitely* be enabled by default - platforms expect the OS to support
> it. If we want to get rid of default y then I think it'd make more sense
> to have a CONFIG_DISABLE_PCIEASPM that's under EXPERT, and people who
> really want to disable the code can do so.

I think the fact that the EXPERT didn't get removed in the above bug
is a defintive bug. But I'd go further and think the CONFIG_PCIEASPM
option should be removed entirely. There is absolutely no good reason
to not build this small amount of code if PCIe support is enabled.

 \ /
  Last update: 2020-05-30 13:35    [W:0.087 / U:1.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site