[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mm, memcg: reclaim more aggressively before high allocator throttling
Shakeel Butt writes:
>What was the initial reason to have different behavior in the first place?

This differing behaviour is simply a mistake, it was never intended to be this
deviate from what happens elsewhere. To that extent this patch is as much a bug
fix as it is an improvement.

>> static void high_work_func(struct work_struct *work)
>> @@ -2378,16 +2384,20 @@ void mem_cgroup_handle_over_high(void)
>> {
>> unsigned long penalty_jiffies;
>> unsigned long pflags;
>> + unsigned long nr_reclaimed;
>> unsigned int nr_pages = current->memcg_nr_pages_over_high;
>Is there any benefit to keep current->memcg_nr_pages_over_high after
>this change? Why not just use SWAP_CLUSTER_MAX?

I don't feel strongly either way, but current->memcg_nr_pages_over_high can be
very large for large allocations.

That said, maybe we should just reclaim `max(SWAP_CLUSTER_MAX, current - high)`
for each loop? I agree that with this design it looks like perhaps we don't
need it any more.

Johannes, what do you think?

 \ /
  Last update: 2020-05-28 21:48    [W:0.197 / U:21.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site