[lkml]   [2020]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] MIPS: fw: arc: add __weak to prom_meminit and prom_free_prom_memory
On Mon, 6 Apr 2020, Masahiro Yamada wrote:

> > > As far as I understood, prom_meminit() in arch/mips/fw/arc/memory.c
> > > is overridden by the one in arch/mips/sgi-ip32/ip32-memory.c if
> > > CONFIG_SGI_IP32 is enabled.
> > >
> > > The use of EXPORT_SYMBOL in static libraries potentially causes a
> > > problem for the llvm linker [1]. So, I want to forcibly link lib-y
> > > objects to vmlinux when CONFIG_MODULES=y.
> >
> > It looks to me like a bug in the linker in the handling of the EXTERN
> > command. Why not fix the linker instead?
> I am not sure if this is a bug.
> Anyway, they decided to not change ld.lld

Well, maybe that was a conscious decision, however it's a linker feature
that has been there since forever and projects like Linux can legitimately
rely on it. In this case perhaps sticking to other linkers, which have
the right features, is the right solution rather than trying to turn a
complex and mature project like Linux upside down (and quite possibly
introducing bugs and pessimisations on the way) just to match an inferior
tool. Adapt your tool to the task, not the task to your tool.

> MIPS code is so confusing.
> There are multiple definitions,
> and lib.a is (ab)used to hide them.

It's a standard feature of libraries that a symbol reference is satisfied
by the first symbol definition encountered. Any extra ones provided later
in the link order are ignored. And we have control over the link order.

> I fixed another one for MIPS before, and
> 0-day bot reported this recently.
> There are lots of prom_meminit() definitions
> in arch/mips/.

Naturally, many platforms will have its own, in addition to some generic
(possibly dummy) one.

> Making the intention clearer is a good thing, IMHO.

Hmm, what intention? Can you please be more specific?


 \ /
  Last update: 2020-04-06 13:55    [W:0.067 / U:1.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site