lkml.org 
[lkml]   [2020]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] [PATCH v2 1/5] scsi: ufs: Allow UFS 3.0 as a valid version
Date
From: Bean Huo (beanhuo) <beanhuo@micron.com>
Date: Apr/24/2020, 16:57:07 (UTC+00:00)

> Hi, Jose
>
> > @@ -8441,7 +8441,8 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem
> > *mmio_base, unsigned int irq)
> > if ((hba->ufs_version != UFSHCI_VERSION_10) &&
> > (hba->ufs_version != UFSHCI_VERSION_11) &&
> > (hba->ufs_version != UFSHCI_VERSION_20) &&
> > - (hba->ufs_version != UFSHCI_VERSION_21))
> > + (hba->ufs_version != UFSHCI_VERSION_21) &&
> > + (hba->ufs_version != UFSHCI_VERSION_30))
>
> I don't think these checkups of UFSHCI version is necessary, does the UFSHCI have other version number except these?
> Is there somebody still v1.0 and v1.1?

Probably. I think we can leave them or change the dev_err to a dev_warn.
This way we have logs in case someone is using a non-supported version.

What do you think ?

---
Thanks,
Jose Miguel Abreu

\
 
 \ /
  Last update: 2020-04-29 08:51    [W:0.417 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site